Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix active-active value #240

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix active-active value #240

merged 1 commit into from
Nov 9, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Nov 8, 2023 •
edited
Loading

Background

Jira TF-8610

Just noticed this error that I wanted to fix real quick. It ensures that the operational mode is Active/Active and not external if there are two or more nodes.

How Has This Been Tested

Below there are 10 passing tests, however, some of the destroys failed due to cloud provider issues so it looks messy. Here are the direct links to the passing tests:

FDO

Replicated

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 8, 2023 •
edited by github-actions bot
Loading

/test all

✅ Terraform Azure Standalone Mounted Disk (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

✅ Terraform Azure Standalone Mounted Disk (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

❌ Terraform Azure Standalone External (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ❌ Terraform Destroy

❌ Terraform Azure Standalone External (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ❌ Terraform Destroy

❌ Terraform Azure Public Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

  • ✅ Terraform Destroy

✅ Terraform Azure Private TCP Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

✅ Terraform Azure Public Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

✅ Terraform Azure Private Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

❌ Terraform Azure Private TCP Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

  • ✅ Terraform Destroy

❌ Terraform Azure Private Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 9, 2023 •
edited by github-actions bot
Loading

/destroy standalone-external

✅ Terraform Azure Standalone External (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 9, 2023 •
edited by github-actions bot
Loading

/destroy standalone-external-replicated

✅ Terraform Azure Standalone External (Replicated) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 9, 2023 •
edited by github-actions bot
Loading

/test private-active-active

✅ Terraform Azure Private Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 9, 2023 •
edited by github-actions bot
Loading

/test private-tcp-active-active-replicated

✅ Terraform Azure Private TCP Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 9, 2023 •
edited by github-actions bot
Loading

/test public-active-active

✅ Terraform Azure Public Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth anniehedgpeth marked this pull request as ready for review November 9, 2023 23:39
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner November 9, 2023 23:39
@anniehedgpeth anniehedgpeth merged commit 8d15272 into main Nov 9, 2023
4 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/fix-operational-mode branch November 9, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0pr0ck5 p0pr0ck5 p0pr0ck5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anniehedgpeth @p0pr0ck5